-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: time range for umap #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You can actually click on the timeseries graph now to test this out.
( | ||
() | ||
if dataset is None | ||
else ( | ||
( | ||
EventId(row_id, dataset_id), | ||
dataset.get_embedding_vector_column(self.name).iloc[row_id], | ||
) | ||
for row_id in range( | ||
*row_interval_from_sorted_time_index( | ||
dataset.dataframe.index, start=time_range.start, end=time_range.end | ||
) | ||
)[:n_samples] | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is black formatting but something about this way of iterating is pretty hard to read. Non blocking but is there a way this can be made slightly easier to read?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have some ideas for syntax sugar for time filtering in general. will do that in a follow-up PR.
lgtm |
resolves #311