fix: time range for umap #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeldking
approved these changes
Mar 2, 2023
Comment on lines
+206
to
+220
| ( | ||
| () | ||
| if dataset is None | ||
| else ( | ||
| ( | ||
| EventId(row_id, dataset_id), | ||
| dataset.get_embedding_vector_column(self.name).iloc[row_id], | ||
| ) | ||
| for row_id in range( | ||
| *row_interval_from_sorted_time_index( | ||
| dataset.dataframe.index, start=time_range.start, end=time_range.end | ||
| ) | ||
| )[:n_samples] | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I know this is black formatting but something about this way of iterating is pretty hard to read. Non blocking but is there a way this can be made slightly easier to read?
There was a problem hiding this comment.
i have some ideas for syntax sugar for time filtering in general. will do that in a follow-up PR.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #311